cleanup logging

[psensor.git] / src / lib / hdd_atasmart.c

diff --git a/src/lib/hdd_atasmart.c b/src/lib/hdd_atasmart.c
index 679d874..051e09c 100644 (file)
--- a/src/lib/hdd_atasmart.c
+++ b/src/lib/hdd_atasmart.c
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2010-2012 jeanfi@gmail.com
+ * Copyright (C) 2010-2014 jeanfi@gmail.com
  *
  * This program is free software; you can redistribute it and/or
  * modify it under the terms of the GNU General Public License as
@@ -16,6 +16,9 @@
  * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
  * 02110-1301 USA
  */
+#define _LARGEFILE_SOURCE 1
+#include "config.h"
+
 #include <locale.h>
 #include <libintl.h>
 #define _(str) gettext(str)
@@ -32,9 +35,11 @@
 #include <atasmart.h>
 #include <linux/fs.h>
 
-#include "pio.h"
-#include "hdd.h"
-#include "log.h"
+#include <pio.h>
+#include <hdd.h>
+#include <plog.h>
+
+static const char *PROVIDER_NAME = "atasmart";
 
 static int filter_sd(const char *p)
 {
@@ -45,9 +50,14 @@ static struct psensor *
 create_sensor(char *id, char *name, SkDisk *disk, int values_max_length)
 {
        struct psensor *s;
+       int t;
+
+       t = SENSOR_TYPE_ATASMART | SENSOR_TYPE_HDD | SENSOR_TYPE_TEMP;
+
        s = psensor_create(id,
                           strdup(name),
-                          SENSOR_TYPE_HDD_TEMP_ATASMART,
+                          strdup(_("Disk")),
+                          t,
                           values_max_length);
 
        s->disk = disk;
@@ -64,39 +74,34 @@ static void analyze_disk(const char *dname)
        struct stat st;
        uint64_t size;
 
-       log_debug("analyze_disk(hdd_atasmart): %s", dname);
+       log_fct("Analyze %s", dname);
 
        f = open(dname, O_RDONLY|O_NOCTTY|O_NONBLOCK|O_CLOEXEC);
 
        if (f < 0) {
-               log_debug("analyze_disk(hdd_atasmart): Could not open file %s: %s",
-                         dname,
-                         strerror(errno));
+               log_fct("Could not open file %s: %s", dname, strerror(errno));
                goto fail;
        }
 
        if (fstat(f, &st) < 0) {
-               log_debug("analyze_disk(hdd_atasmart): fstat fails %s: %s",
-                         dname,
-                         strerror(errno));
+               log_fct("fstat fails %s: %s", dname, strerror(errno));
                goto fail;
        }
 
        if (!S_ISBLK(st.st_mode)) {
-               log_debug("analyze_disk(hdd_atasmart): !S_ISBLK fails %s",
-                         dname);
+               log_fct("!S_ISBLK fails %s", dname);
                goto fail;
        }
 
        size = (uint64_t)-1;
        /* So, it's a block device. Let's make sure the ioctls work */
        if (ioctl(f, BLKGETSIZE64, &size) < 0) {
-               log_debug("ioctl fails %s: %s", dname, strerror(errno));
+               log_fct("ioctl fails %s: %s", dname, strerror(errno));
                goto fail;
        }
 
        if (size <= 0 || size == (uint64_t) -1) {
-               log_debug("ioctl wrong size %s: %ld", dname, size);
+               log_fct("ioctl wrong size %s: %ld", dname, size);
                goto fail;
        }
 
@@ -111,19 +116,21 @@ struct psensor **hdd_psensor_list_add(struct psensor **sensors,
        SkDisk *disk;
        struct psensor *sensor, **tmp_sensors, **result;
 
-       log_debug("hdd_psensor_list_add(hdd_atasmart)");
+       log_fct_enter();
 
        paths = dir_list("/dev", filter_sd);
 
        result = sensors;
        tmp = paths;
        while (*tmp) {
-               log_debug("hdd_psensor_list_add(hdd_atasmart) open %s", *tmp);
+               log_fct("Open %s", *tmp);
 
                if (!sk_disk_open(*tmp, &disk)) {
-                       id = malloc(strlen("hdd at") + strlen(*tmp) + 1);
-                       strcpy(id, "hdd at");
-                       strcat(id, *tmp);
+                       id = malloc(strlen(PROVIDER_NAME)
+                                   + 1
+                                   + strlen(*tmp)
+                                   + 1);
+                       sprintf(id, "%s %s", PROVIDER_NAME, *tmp);
 
                        sensor = create_sensor(id,
                                               *tmp,
@@ -137,7 +144,9 @@ struct psensor **hdd_psensor_list_add(struct psensor **sensors,
 
                        result = tmp_sensors;
                } else {
-                       log_err("sk_disk_open(hdd_atasmart) %s failure", *tmp);
+                       log_err(_("%s: sk_disk_open() failure: %s."),
+                               PROVIDER_NAME,
+                               *tmp);
                        analyze_disk(*tmp);
                }
 
@@ -146,6 +155,8 @@ struct psensor **hdd_psensor_list_add(struct psensor **sensors,
 
        paths_free(paths);
 
+       log_fct_exit();
+
        return result;
 }
 
@@ -159,7 +170,8 @@ void hdd_psensor_list_update(struct psensor **sensors)
        cur = sensors;
        while (*cur) {
                s = *cur;
-               if (s->type == SENSOR_TYPE_HDD_TEMP_ATASMART) {
+               if (!(s->type & SENSOR_TYPE_REMOTE)
+                   && s->type & SENSOR_TYPE_ATASMART) {
                        ret = sk_disk_smart_read_data(s->disk);
 
                        if (!ret) {
@@ -169,9 +181,7 @@ void hdd_psensor_list_update(struct psensor **sensors)
                                if (!ret) {
                                        c = (kelvin - 273150) / 1000;
                                        psensor_set_current_value(s, c);
-                                       log_debug("hdd_psensor_list_update(hdd_atasmart): %s %.2f",
-                                                 s->id,
-                                                 c);
+                                       log_fct("%s %.2f", s->id, c);
                                }
                        }
                }