avoid to store unknown values for the sensor

[psensor.git] / src / lib / cpu.c

diff --git a/src/lib/cpu.c b/src/lib/cpu.c
index 9f26db9..3388455 100644 (file)
--- a/src/lib/cpu.c
+++ b/src/lib/cpu.c
@@ -26,20 +26,20 @@
 
 #include "cpu.h"
 
-static glibtop_cpu *cpu;
 static float last_used;
 static float last_total;
 
+static const char *PROVIDER_NAME = "gtop2";
+
 struct psensor *create_cpu_usage_sensor(int measures_len)
 {
-       char *label;
+       char *label, *id;
        int type;
-       char *id;
        struct psensor *psensor;
 
-       id = strdup("cpu usage");
-       label = strdup("cpu usage");
-       type = SENSOR_TYPE_CPU_USAGE;
+       id = g_strdup_printf("%s cpu usage", PROVIDER_NAME);
+       label = strdup(_("CPU usage"));
+       type = SENSOR_TYPE_GTOP | SENSOR_TYPE_CPU_USAGE;
 
        psensor = psensor_create(id,
                                 label,
@@ -62,51 +62,49 @@ cpu_psensor_list_add(struct psensor **sensors, int measures_len)
 
 static double get_usage()
 {
-       unsigned long int used = 0;
+       glibtop_cpu cpu;
+       unsigned long int used;
        unsigned long int dt;
-       double cpu_rate = UNKNOWN_DBL_VALUE;
-
-       if (!cpu)
-               cpu = malloc(sizeof(glibtop_cpu));
+       double cpu_rate;
 
-       glibtop_get_cpu(cpu);
+       glibtop_get_cpu(&cpu);
 
-       used = cpu->user + cpu->nice + cpu->sys;
+       used = cpu.user + cpu.nice + cpu.sys;
 
-       dt = cpu->total - last_total;
+       dt = cpu.total - last_total;
 
        if (dt)
-               cpu_rate = 100 * (used - last_used) / dt;
+               cpu_rate = 100.0 * (used - last_used) / dt;
+       else
+               cpu_rate = UNKNOWN_DBL_VALUE;
 
        last_used = used;
-       last_total = cpu->total;
+       last_total = cpu.total;
 
        return cpu_rate;
 }
 
 void cpu_usage_sensor_update(struct psensor *s)
 {
-       psensor_set_current_value(s, get_usage());
+       double v;
+
+       v = get_usage();
+
+       if (v != UNKNOWN_DBL_VALUE)
+               psensor_set_current_value(s, v);
 }
 
 void cpu_psensor_list_update(struct psensor **sensors)
 {
-       struct psensor **ss, *s;
+       struct psensor *s;
 
-       ss = sensors;
-       while (*ss) {
-               s = *ss;
+       while (*sensors) {
+               s = *sensors;
 
-               if (!(s->type & SENSOR_TYPE_REMOTE)
-                   && s->type == SENSOR_TYPE_CPU_USAGE)
+               if (s->type & SENSOR_TYPE_GTOP
+                   && s->type & SENSOR_TYPE_CPU_USAGE)
                        cpu_usage_sensor_update(s);
 
-               ss++;
+               sensors++;
        }
 }
-
-void cpu_cleanup()
-{
-       if (cpu)
-               free(cpu);
-}