cleanup
[psensor.git] / src / graph.c
index a69b65a..ac929fa 100644 (file)
 #include <glib/gi18n.h>
 #include <gtk/gtk.h>
 
+#include <math.h>
+
 #include <cfg.h>
 #include <plog.h>
 #include <psensor.h>
 
 /* horizontal padding */
-#define GRAPH_H_PADDING 4
+const int GRAPH_H_PADDING = 4;
 /* vertical padding */
-#define GRAPH_V_PADDING 4
+const int GRAPH_V_PADDING = 4;
+
+bool is_smooth_curves_enabled;
+
+struct graph_info {
+       /* Horizontal position of the central area (curves) */
+       int g_xoff;
+       /* Vertical position of the central area (curves) */
+       int g_yoff;
+
+       /* Width of the central area (curves) */
+       int g_width;
+       /* Height of the central area (curves) */
+       int g_height;
+
+       /* Height of the drawing canvas */
+       int height;
+       /* Width of the drawing canvas */
+       int width;
+
+       /* Background color of the current desktop theme */
+       GdkRGBA theme_bg_color;
+       /* Foreground color of the current desktop theme */
+       GdkRGBA theme_fg_color;
+};
+
 
-static time_t get_graph_end_time_s()
+/* Return the end time of the graph i.e. the more recent measure.  If
+ * no measure are available, return 0.
+ */
+static time_t get_graph_end_time_s(struct psensor **sensors)
 {
-       struct timeval tv;
+       time_t ret, t;
+       struct psensor *s;
+       struct measure *measures;
+       int i;
 
-       if (gettimeofday(&tv, NULL) == 0)
-               return tv.tv_sec;
-       else
-               return 0;
-}
+       ret = 0;
+       while (*sensors) {
+               s = *sensors;
+               measures = s->measures;
 
-static time_t get_graph_begin_time_s(struct config *cfg)
-{
-       int ct;
+               for (i = s->values_max_length - 1; i >= 0; i--) {
+                       if (measures[i].value != UNKNOWN_DBL_VALUE) {
+                               t = measures[i].time.tv_sec;
+
+                               if (t > ret)
+                                       ret = t;
+                       }
+                       i--;
+               }
+
+               sensors++;
+       }
 
-       ct = get_graph_end_time_s();
+       return ret;
+}
 
-       if (!ct)
+static time_t get_graph_begin_time_s(struct config *cfg, time_t etime)
+{
+       if (!etime)
                return 0;
 
-       return ct - cfg->graph_monitoring_duration * 60;
+       return etime - cfg->graph_monitoring_duration * 60;
 }
 
 static double
 compute_y(double value, double min, double max, int height, int off)
 {
        double t = value - min;
+
        return height - ((double)height * (t / (max - min))) + off;
 }
 
@@ -77,39 +122,41 @@ static char *time_to_str(time_t s)
        return str;
 }
 
+static void draw_left_region(cairo_t *cr, struct graph_info *info)
+{
+       cairo_set_source_rgb(cr,
+                            info->theme_bg_color.red,
+                            info->theme_bg_color.green,
+                            info->theme_bg_color.blue);
+
+       cairo_rectangle(cr, 0, 0, info->g_xoff, info->height);
+       cairo_fill(cr);
+}
+
 static void
 draw_graph_background(cairo_t *cr,
-                     int g_xoff, int g_yoff,
-                     int g_width, int g_height,
-                     int width, int height, struct config *config,
-                     GtkWidget *widget,
-                     GtkWidget *window)
+                     struct config *config,
+                     struct graph_info *info)
 {
-       GtkStyleContext *style_ctx;
        struct color *bgcolor;
-       GdkRGBA rgba;
 
        bgcolor = config->graph_bgcolor;
 
-       style_ctx = gtk_widget_get_style_context(window);
-       gtk_style_context_get_background_color(style_ctx,
-                                              GTK_STATE_FLAG_NORMAL,
-                                              &rgba);
-
        if (config->alpha_channel_enabled)
                cairo_set_source_rgba(cr,
-                                     rgba.red,
-                                     rgba.green,
-                                     rgba.blue,
+                                     info->theme_bg_color.red,
+                                     info->theme_bg_color.green,
+                                     info->theme_bg_color.blue,
                                      config->graph_bg_alpha);
        else
                cairo_set_source_rgb(cr,
-                                    rgba.red,
-                                    rgba.green,
-                                    rgba.blue);
+                                    info->theme_bg_color.red,
+                                    info->theme_bg_color.green,
+                                    info->theme_bg_color.blue);
 
-       cairo_rectangle(cr, 0, 0, width, height);
+       cairo_rectangle(cr, info->g_xoff, 0, info->g_width, info->height);
        cairo_fill(cr);
+
        if (config->alpha_channel_enabled)
                cairo_set_source_rgba(cr,
                                      bgcolor->red,
@@ -122,7 +169,11 @@ draw_graph_background(cairo_t *cr,
                                     bgcolor->green,
                                     bgcolor->blue);
 
-       cairo_rectangle(cr, g_xoff, g_yoff, g_width, g_height);
+       cairo_rectangle(cr,
+                       info->g_xoff,
+                       info->g_yoff,
+                       info->g_width,
+                       info->g_height);
        cairo_fill(cr);
 }
 
@@ -135,9 +186,8 @@ static int ndash = sizeof(dashes) / sizeof(dashes[0]);
 
 static void draw_background_lines(cairo_t *cr,
                                  struct color *color,
-                                 int g_width, int g_height,
-                                 int g_xoff, int g_yoff,
-                                 int min, int max)
+                                 int min, int max,
+                                 struct graph_info *info)
 {
        int i;
 
@@ -149,19 +199,24 @@ static void draw_background_lines(cairo_t *cr,
 
        /* vertical lines representing time steps */
        for (i = 0; i <= 5; i++) {
-               int x = i * (g_width / 5) + g_xoff;
-               cairo_move_to(cr, x, g_yoff);
-               cairo_line_to(cr, x, g_yoff + g_height);
+               int x = i * (info->g_width / 5) + info->g_xoff;
+
+               cairo_move_to(cr, x, info->g_yoff);
+               cairo_line_to(cr, x, info->g_yoff + info->g_height);
                cairo_stroke(cr);
        }
 
        /* horizontal lines draws a line for each 10C step */
        for (i = min; i < max; i++) {
                if (i % 10 == 0) {
-                       int y = compute_y(i, min, max, g_height, g_yoff);
-
-                       cairo_move_to(cr, g_xoff, y);
-                       cairo_line_to(cr, g_xoff + g_width, y);
+                       int y = compute_y(i,
+                                         min,
+                                         max,
+                                         info->g_height,
+                                         info->g_yoff);
+
+                       cairo_move_to(cr, info->g_xoff, y);
+                       cairo_line_to(cr, info->g_xoff + info->g_width, y);
                        cairo_stroke(cr);
                }
        }
@@ -170,8 +225,11 @@ static void draw_background_lines(cairo_t *cr,
        cairo_set_dash(cr, 0, 0, 0);
 }
 
-/* contains the time_t of the measures which have been draw ie not the
- * bezier control points for each sensor. */
+/* Keys: sensor identifier.
+ *
+ * Values: array of time_t. Each time_t is corresponding to a sensor
+ * measure which has been used as the start point of a Bezier curve.
+ */
 static GHashTable *times;
 
 static void draw_sensor_smooth_curve(struct psensor *s,
@@ -180,10 +238,7 @@ static void draw_sensor_smooth_curve(struct psensor *s,
                                     double max,
                                     int bt,
                                     int et,
-                                    int g_width,
-                                    int g_height,
-                                    int g_xoff,
-                                    int g_yoff)
+                                    struct graph_info *info)
 {
        int i, dt, vdt, j, k, found;
        double x[4], y[4], v;
@@ -202,6 +257,10 @@ static void draw_sensor_smooth_curve(struct psensor *s,
                             s->color->green,
                             s->color->blue);
 
+       /* search the index of the first measure used as a start point
+        * of a Bezier curve. The start and end points of the Bezier
+        * curves must be preserved to ensure the same overall shape
+        * of the graph. */
        i = 0;
        if (stimes) {
                while (i < s->values_max_length) {
@@ -250,9 +309,13 @@ static void draw_sensor_smooth_curve(struct psensor *s,
 
                        vdt = t - bt;
 
-                       x[0 + j] = ((double)vdt * g_width) / dt + g_xoff;
-                       y[0 + j] = compute_y(v, min, max, g_height, g_yoff);
-
+                       x[0 + j] = ((double)vdt * info->g_width)
+                               / dt + info->g_xoff;
+                       y[0 + j] = compute_y(v,
+                                            min,
+                                            max,
+                                            info->g_height,
+                                            info->g_yoff);
 
                        if (j == 0)
                                t0 = t;
@@ -278,10 +341,7 @@ static void draw_sensor_curve(struct psensor *s,
                              double max,
                              int bt,
                              int et,
-                             int g_width,
-                             int g_height,
-                             int g_xoff,
-                             int g_yoff)
+                             struct graph_info *info)
 {
        int first, i, t, dt, vdt;
        double v, x, y;
@@ -301,12 +361,10 @@ static void draw_sensor_curve(struct psensor *s,
                        continue;
 
                vdt = t - bt;
-               if (vdt < 0)
-                       continue;
 
-               x = ((double)vdt * g_width) / dt + g_xoff;
+               x = ((double)vdt * info->g_width) / dt + info->g_xoff;
 
-               y = compute_y(v, min, max, g_height, g_yoff);
+               y = compute_y(v, min, max, info->g_height, info->g_yoff);
 
                if (first) {
                        cairo_move_to(cr, x, y);
@@ -345,10 +403,10 @@ graph_update(struct psensor **sensors,
 {
        struct color *fgcolor = config->graph_fgcolor;
        int et, bt, width, height, g_width, g_height;
-       double min_rpm, max_rpm, mint, maxt;
+       double min_rpm, max_rpm, mint, maxt, min, max;
        char *strmin, *strmax;
        /* horizontal and vertical offset of the graph */
-       int g_xoff, g_yoff, no_graphs, min, max;
+       int g_xoff, g_yoff, no_graphs;
        cairo_surface_t *cst;
        cairo_t *cr, *cr_pixmap;
        char *str_btime, *str_etime;
@@ -356,10 +414,10 @@ graph_update(struct psensor **sensors,
        struct psensor **sensor_cur, **enabled_sensors;
        GtkAllocation galloc;
        GtkStyleContext *style_ctx;
-       GdkRGBA rgba;
+       struct graph_info info;
 
        if (!gtk_widget_is_drawable(w_graph))
-               return ;
+               return;
 
        enabled_sensors = psensor_list_filter_graph_enabled(sensors);
 
@@ -376,12 +434,18 @@ graph_update(struct psensor **sensors,
                                      maxt,
                                      config->temperature_unit == CELSIUS);
 
-       str_btime = time_to_str(get_graph_begin_time_s(config));
-       str_etime = time_to_str(get_graph_end_time_s());
+       et = get_graph_end_time_s(enabled_sensors);
+       bt = get_graph_begin_time_s(config, et);
+
+       str_btime = time_to_str(bt);
+       str_etime = time_to_str(et);
 
        gtk_widget_get_allocation(w_graph, &galloc);
        width = galloc.width;
+       info.width = galloc.width;
        height = galloc.height;
+       info.height = height;
+
 
        cst = cairo_image_surface_create(CAIRO_FORMAT_ARGB32, width, height);
        cr = cairo_create(cst);
@@ -398,6 +462,7 @@ graph_update(struct psensor **sensors,
        cairo_text_extents(cr, strmin, &te_min);
 
        g_yoff = GRAPH_V_PADDING;
+       info.g_yoff = g_yoff;
 
        g_height = height - GRAPH_V_PADDING;
        if (te_etime.height > te_btime.height)
@@ -405,23 +470,34 @@ graph_update(struct psensor **sensors,
        else
                g_height -= GRAPH_V_PADDING + te_btime.height + GRAPH_V_PADDING;
 
+       info.g_height = g_height;
+
        if (te_min.width > te_max.width)
                g_xoff = (2 * GRAPH_H_PADDING) + te_max.width;
        else
                g_xoff = (2 * GRAPH_H_PADDING) + te_min.width;
 
+       info.g_xoff = g_xoff;
+
+       style_ctx = gtk_widget_get_style_context(window);
+       gtk_style_context_get_background_color(style_ctx,
+                                              GTK_STATE_FLAG_NORMAL,
+                                              &info.theme_bg_color);
+       gtk_style_context_get_color(style_ctx,
+                                   GTK_STATE_FLAG_NORMAL,
+                                   &info.theme_fg_color);
+
+
        g_width = width - g_xoff - GRAPH_H_PADDING;
+       info.g_width = g_width;
 
-       draw_graph_background(cr,
-                             g_xoff, g_yoff, g_width, g_height,
-                             width, height, config,
-                             w_graph,
-                             window);
+       draw_graph_background(cr, config, &info);
 
-       /** Set the color for text drawing */
-       style_ctx = gtk_widget_get_style_context(window);
-       gtk_style_context_get_color(style_ctx, GTK_STATE_FLAG_NORMAL, &rgba);
-       cairo_set_source_rgb(cr, rgba.red, rgba.green, rgba.blue);
+       /* Set the color for text drawing */
+       cairo_set_source_rgb(cr,
+                            info.theme_fg_color.red,
+                            info.theme_fg_color.green,
+                            info.theme_fg_color.blue);
 
        /* draw graph begin time */
        cairo_move_to(cr, g_xoff, height - GRAPH_V_PADDING);
@@ -435,25 +511,9 @@ graph_update(struct psensor **sensors,
        cairo_show_text(cr, str_etime);
        free(str_etime);
 
-       /* draw min and max temp */
-       cairo_move_to(cr, GRAPH_H_PADDING, te_max.height + GRAPH_V_PADDING);
-       cairo_show_text(cr, strmax);
-       free(strmax);
-
-       cairo_move_to(cr,
-                     GRAPH_H_PADDING, height - (te_min.height / 2) - g_yoff);
-       cairo_show_text(cr, strmin);
-       free(strmin);
-
-       draw_background_lines(cr, fgcolor,
-                             g_width, g_height,
-                             g_xoff, g_yoff,
-                             mint, maxt);
+       draw_background_lines(cr, fgcolor, mint, maxt, &info);
 
        /* .. and finaly draws the temperature graphs */
-       bt = get_graph_begin_time_s(config);
-       et = get_graph_end_time_s();
-
        if (bt && et) {
                sensor_cur = enabled_sensors;
 
@@ -476,18 +536,16 @@ graph_update(struct psensor **sensors,
                                max = maxt;
                        }
 
-                       if (1)
+                       if (is_smooth_curves_enabled)
                                draw_sensor_smooth_curve(s, cr,
                                                         min, max,
                                                         bt, et,
-                                                        g_width, g_height,
-                                                        g_xoff, g_yoff);
+                                                        &info);
                        else
                                draw_sensor_curve(s, cr,
                                                  min, max,
                                                  bt, et,
-                                                 g_width, g_height,
-                                                 g_xoff, g_yoff);
+                                                 &info);
 
                        sensor_cur++;
                }
@@ -498,6 +556,23 @@ graph_update(struct psensor **sensors,
                                                  g_height / 2);
        }
 
+       draw_left_region(cr, &info);
+
+       /* draw min and max temp */
+       cairo_set_source_rgb(cr,
+                            info.theme_fg_color.red,
+                            info.theme_fg_color.green,
+                            info.theme_fg_color.blue);
+
+       cairo_move_to(cr, GRAPH_H_PADDING, te_max.height + GRAPH_V_PADDING);
+       cairo_show_text(cr, strmax);
+       free(strmax);
+
+       cairo_move_to(cr,
+                     GRAPH_H_PADDING, height - (te_min.height / 2) - g_yoff);
+       cairo_show_text(cr, strmin);
+       free(strmin);
+
        cr_pixmap = gdk_cairo_create(gtk_widget_get_window(w_graph));
 
        if (cr_pixmap) {
@@ -514,3 +589,15 @@ graph_update(struct psensor **sensors,
        cairo_surface_destroy(cst);
        cairo_destroy(cr);
 }
+
+int compute_values_max_length(struct config *c)
+{
+       int n, duration, interval;
+
+       duration = c->graph_monitoring_duration * 60;
+       interval = c->sensor_update_interval;
+
+       n = 3 + ceil((((double)duration) / interval) + 0.5) + 3;
+
+       return n;
+}