Fixed memory issue (patch submitted by Lekensteyn).

[ppastats.git] / src / lp_ws.c

diff --git a/src/lp_ws.c b/src/lp_ws.c
index 6c2e299..d6f4087 100644 (file)
--- a/src/lp_ws.c
+++ b/src/lp_ws.c
@@ -121,23 +121,24 @@ json_object_to_binary_package_publishing_history_list
 
 struct binary_package_publishing_history * *
 get_binary_package_publishing_history_list(const char *archive_url,
-                                          const char *package_status)
+                                          const char *pkg_status)
 {
        struct json_object *o_next;
-       char *url = malloc(strlen(archive_url)+
-                          strlen(QUERY_GET_PUBLISHED_BINARIES)+
-                          strlen("&status=")+
-                          9+
-                          1);
+       char *url;
        json_object *o;
        void **result = NULL;
 
+       url = malloc(strlen(archive_url)+
+                    strlen(QUERY_GET_PUBLISHED_BINARIES)+
+                    (pkg_status ? strlen("&status=")+strlen(pkg_status) : 0)+
+                    1);
+
        strcpy(url, archive_url);
        strcat(url, QUERY_GET_PUBLISHED_BINARIES);
 
-       if (package_status) {
+       if (pkg_status) {
                strcat(url, "&status=");
-               strcat(url, package_status);
+               strcat(url, pkg_status);
        }
 
        while (url) {