cleanup

[psensor.git] / src / main.c

diff --git a/src/main.c b/src/main.c
index f06ea5b..0b2d484 100644 (file)
--- a/src/main.c
+++ b/src/main.c
@@ -58,9 +58,7 @@
 #include "rsensor.h"
 #endif
 
-#if defined(HAVE_APPINDICATOR) || defined(HAVE_APPINDICATOR_029)
 #include "ui_appindicator.h"
-#endif
 
 #ifdef HAVE_LIBNOTIFY
 #include "ui_notify.h"
@@ -176,6 +174,31 @@ void update_psensor_measures(struct ui_psensor *ui)
        }
 }
 
+static void indicators_update(struct ui_psensor *ui)
+{
+       struct psensor **sensor_cur = ui->sensors;
+       unsigned int attention = 0;
+
+       while (*sensor_cur) {
+               struct psensor *s = *sensor_cur;
+
+               if (s->alarm_enabled && s->alarm_raised) {
+                       attention = 1;
+                       break;
+               }
+
+               sensor_cur++;
+       }
+
+#if defined(HAVE_APPINDICATOR) || defined(HAVE_APPINDICATOR_029)
+       if (is_appindicator_supported())
+               ui_appindicator_update(ui, attention);
+#endif
+
+       if (is_status_supported())
+               ui_status_update(ui, attention);
+}
+
 gboolean ui_refresh_thread(gpointer data)
 {
        struct config *cfg;
@@ -191,9 +214,8 @@ gboolean ui_refresh_thread(gpointer data)
 
        ui_sensorlist_update(ui);
 
-#if defined(HAVE_APPINDICATOR) || defined(HAVE_APPINDICATOR_029)
-       ui_appindicator_update(ui);
-#endif
+       if (is_appindicator_supported() || is_status_supported())
+               indicators_update(ui);
 
 #ifdef HAVE_UNITY
        ui_unity_launcher_entry_update(ui->sensors,
@@ -329,6 +351,24 @@ static struct option long_options[] = {
        {0, 0, 0, 0}
 };
 
+static gboolean initial_window_show(gpointer data)
+{
+       struct ui_psensor *ui;
+
+       ui = (struct ui_psensor *)data;
+
+       log_printf(LOG_DEBUG,
+                  "is_status_supported: %d\n", is_status_supported());
+
+       if (!ui->config->hide_on_startup
+           || (!is_appindicator_supported() && !is_status_supported()))
+               ui_window_show(ui);
+
+       ui_window_update(ui);
+
+       return FALSE;
+}
+
 int main(int argc, char **argv)
 {
        struct ui_psensor ui;
@@ -422,6 +462,8 @@ int main(int argc, char **argv)
        associate_colors(ui.sensors);
        associate_cb_alarm_raised(ui.sensors, &ui);
 
+       ui_status_init(&ui);
+
        /* main window */
        ui_window_create(&ui);
        ui.sensor_box = NULL;
@@ -432,7 +474,13 @@ int main(int argc, char **argv)
        /* sensor list */
        ui_sensorlist_create(&ui);
 
-       ui_window_update(&ui);
+       /*
+        * show the window as soon as all gtk events have been processed
+        * in order to ensure that the status icon is attempted to be
+        * drawn before. If not, there is no way to detect that it is
+        * visible.
+       */
+       g_idle_add((GSourceFunc)initial_window_show, &ui);
 
        thread = g_thread_create((GThreadFunc) update_psensor_measures,
                                 &ui, TRUE, &error);
@@ -446,8 +494,6 @@ int main(int argc, char **argv)
 
 #if defined(HAVE_APPINDICATOR) || defined(HAVE_APPINDICATOR_029)
        ui_appindicator_init(&ui);
-#else
-       ui_status_init();
 #endif
 
        gdk_notify_startup_complete();
@@ -474,10 +520,10 @@ int main(int argc, char **argv)
 
 #if defined(HAVE_APPINDICATOR) || defined(HAVE_APPINDICATOR_029)
        ui_appindicator_cleanup();
-#else
-       ui_status_cleanup();
 #endif
 
+       ui_status_cleanup();
+
        g_mutex_unlock(ui.sensors_mutex);
 
        config_cleanup();