fixed memeroy leaks (glib GError handling)
authorJean-Philippe Orsini <jeanfi@gmail.com>
Mon, 10 Nov 2014 17:41:35 +0000 (18:41 +0100)
committerJean-Philippe Orsini <jeanfi@gmail.com>
Mon, 10 Nov 2014 17:41:35 +0000 (18:41 +0100)
NEWS
src/cfg.c

diff --git a/NEWS b/NEWS
index dc7790e..65a7e28 100644 (file)
--- a/NEWS
+++ b/NEWS
@@ -16,6 +16,7 @@ v1.1.4
 * Made help2man optional.
 * New dconf settings +default-high-threshold-temperature+,
   and +default-sensor-alarm-enabled+.
+* Fixed memory leaks due to glib GError.
 
 v1.1.3
 ------
index d3514cc..37048c9 100644 (file)
--- a/src/cfg.c
+++ b/src/cfg.c
@@ -566,10 +566,12 @@ static GKeyFile *get_sensor_key_file(void)
                                                | G_KEY_FILE_KEEP_TRANSLATIONS,
                                                &err);
 
-               if (!ret)
+               if (!ret) {
                        log_warn(_("Failed to load configuration file %s: %s"),
                                 path,
                                 err->message);
+                       g_error_free(err);
+               }
        }
 
        return key_file;
@@ -652,8 +654,8 @@ static bool sensor_get_bool(const char *sid, const char *att, bool dft)
        bool ret;
 
        kfile = get_sensor_key_file();
-       err = NULL;
 
+       err = NULL;
        ret = g_key_file_get_boolean(kfile, sid, att, &err);
 
        if (err) {