cleanup
authorJean-Philippe Orsini <jeanfi@gmail.com>
Sun, 23 Feb 2014 11:30:57 +0000 (11:30 +0000)
committerJean-Philippe Orsini <jeanfi@gmail.com>
Sun, 23 Feb 2014 11:30:57 +0000 (11:30 +0000)
src/ppastats.c

index 754cf4e..27c402d 100644 (file)
@@ -228,7 +228,8 @@ pkg_add_distro(struct package_stats *pkg,
                pkg_distro = distro_stats_new(distro_name);
                tmp = (struct distro_stats **)list_add((void **)pkg->distros,
                                                       (void *)pkg_distro);
-               free(pkg->distros);
+               if (pkg->distros != tmp)
+                       free(pkg->distros);
                pkg->distros = tmp;
        }
 
@@ -367,22 +368,13 @@ static void distro_stats_list_free(struct distro_stats **distros)
                        distro_stats_free(*distros);
                        distros++;
                }
+               free(distros);
        }
 }
 
 static void version_stats_free(struct version_stats *version)
 {
-       struct distro_stats **distros;
-
-       distros = version->distros;
-       if (distros) {
-               while (*distros) {
-                       distro_stats_free(*distros);
-                       distros++;
-               }
-               free(version->distros);
-       }
-
+       distro_stats_list_free(version->distros);
        daily_download_total_list_free(version->daily_download_totals);
 
        free(version->version);