X-Git-Url: https://git.wpitchoune.net/gitweb/?a=blobdiff_plain;f=src%2Flp_json.c;h=e02ef62f90f3b74b2ca4a947f9c5ac262e488308;hb=99b65b5be32158ebc793df4ab2b825633e32a100;hp=590d3347a1df98653a606279bdff44eb2d3cbc60;hpb=a9435991d03d0bd9e81d6cb6003013bec4b2e6e9;p=ppastats.git

diff --git a/src/lp_json.c b/src/lp_json.c
index 590d334..e02ef62 100644
--- a/src/lp_json.c
+++ b/src/lp_json.c
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2011-2012 jeanfi@gmail.com
+ * Copyright (C) 2011-2014 jeanfi@gmail.com
  *
  * This program is free software; you can redistribute it and/or
  * modify it under the terms of the GNU General Public License as
@@ -23,19 +23,57 @@
 #include <string.h>
 #include <time.h>
 
+#include <config.h>
 #include "lp_json.h"
 #include "lp_ws.h"
 
+/* Declares json_bool to have consistent code even with
+   old json lib releases using boolean instead of json_bool.*/
+#ifndef HAVE_JSON_BOOL
+typedef boolean json_bool;
+#endif
+
+static time_t json_to_time(json_object *json)
+{
+	const char *str;
+	struct tm tm;
+	char *ret;
+
+	str = json_object_get_string(json);
+	if (!str)
+		return -1;
+
+	tm.tm_isdst = -1;
+	ret = strptime(str, "%FT%T", &tm);
+
+	if (ret)
+		return mktime(&tm);
+	else
+		return -1;
+}
+
+static json_object *time_to_json(time_t t)
+{
+	char *str;
+
+	str = time_to_str(t);
+
+	if (str)
+		return json_object_new_string(str);
+	else
+		return NULL;
+}
+
 static struct bpph *json_to_bpph(json_object *o)
 {
 	const char *binary_package_name;
 	const char *binary_package_version;
 	const char *distro_arch_series_link;
 	const char *self_link;
-	int architecture_specific;
-	const char *date_created;
+	int arch_specific;
 	struct bpph *bpph;
 	const char *status;
+	time_t date_created;
 
 	binary_package_name = json_object_get_string
 		(json_object_object_get(o, "binary_package_name"));
@@ -49,26 +87,20 @@ static struct bpph *json_to_bpph(json_object *o)
 	self_link = json_object_get_string
 		(json_object_object_get(o, "self_link"));
 
-	if (json_object_get_boolean
-	    (json_object_object_get(o, "architecture_specific")))
-		architecture_specific = 1;
-	else
-		architecture_specific = 0;
+	arch_specific = json_object_get_boolean
+		(json_object_object_get(o, "architecture_specific"));
+
+	date_created = json_to_time(json_object_object_get(o, "date_created"));
+
+	status = json_object_get_string(json_object_object_get(o, "status"));
 
 	bpph =  bpph_new(binary_package_name,
 			 binary_package_version,
 			 distro_arch_series_link,
 			 self_link,
-			 architecture_specific);
-
-	date_created = json_object_get_string
-		(json_object_object_get(o, "date_created"));
-	if (date_created)
-		strptime(date_created, "%FT%T%z", &bpph->date_created);
-
-	status = json_object_get_string(json_object_object_get(o, "status"));
-	if (status)
-		bpph->status = strdup(status);
+			 status,
+			 arch_specific,
+			 date_created);
 
 	return bpph;
 }
@@ -76,7 +108,6 @@ static struct bpph *json_to_bpph(json_object *o)
 static json_object *bpph_to_json(struct bpph *bpph)
 {
 	json_object *json;
-	char *date;
 
 	json = json_object_new_object();
 
@@ -96,9 +127,7 @@ static json_object *bpph_to_json(struct bpph *bpph)
 		 json_object_new_string(bpph->distro_arch_series_link));
 
 	json_object_object_add
-		(json,
-		 "self_link",
-		 json_object_new_string(bpph->self_link));
+		(json, "self_link", json_object_new_string(bpph->self_link));
 
 	json_object_object_add
 		(json,
@@ -108,15 +137,8 @@ static json_object *bpph_to_json(struct bpph *bpph)
 	json_object_object_add
 		(json, "status", json_object_new_string(bpph->status));
 
-	date = malloc(strlen("YY-MM-DDThh:mm:ss+xxx") + 1);
-	strftime(date,
-		 strlen("YY-MM-DDThh:mm:ss+xxx") + 1,
-		 "%FT%T%z",
-		 &bpph->date_created);
-
 	json_object_object_add
-		(json, "date_created", json_object_new_string(date));
-	free(date);
+		(json, "date_created", time_to_json(bpph->date_created));
 
 	return json;
 }
@@ -126,7 +148,7 @@ struct distro_arch_series *json_object_to_distro_arch_series(json_object *o)
 	const char *display_name;
 	const char *title;
 	const char *architecture_tag;
-	boolean is_nominated_arch_indep;
+	json_bool is_nominated_arch_indep;
 	const char *distroseries_link;
 
 	display_name = json_object_get_string