code style, added missing 'const' (DEFAULT_FETCH_RETRIES)

[ppastats.git] / src / lp_ws.c

diff --git a/src/lp_ws.c b/src/lp_ws.c
index aa6ace7..5eca19a 100644 (file)
--- a/src/lp_ws.c
+++ b/src/lp_ws.c
@@ -19,20 +19,23 @@
 
 #include <stdlib.h>
 #include <string.h>
+#include <unistd.h>
 
 #include <curl/curl.h>
 #include <json/json.h>
 
 #include "cache.h"
+#include "list.h"
 #include "lp_ws.h"
 #include "lp_json.h"
 #include "ppastats.h"
 
-#define QUERY_GET_PUBLISHED_BINARIES \
-       "?ws.op=getPublishedBinaries&status=Published"
-#define QUERY_GET_DOWNLOAD_COUNT "?ws.op=getDownloadCount"
-#define QUERY_GET_DAILY_DOWNLOAD_TOTALS \
-       "?ws.op=getDailyDownloadTotals"
+static const char *QUERY_GET_PUBLISHED_BINARIES = "?ws.op=getPublishedBinaries";
+static const char *QUERY_GET_DOWNLOAD_COUNT = "?ws.op=getDownloadCount";
+static const char *
+QUERY_GET_DAILY_DOWNLOAD_TOTALS = "?ws.op=getDailyDownloadTotals";
+
+static const int DEFAULT_FETCH_RETRIES = 3;
 
 static CURL *curl;
 
@@ -58,13 +61,16 @@ static size_t cbk_curl(void *buffer, size_t size, size_t nmemb, void *userp)
 static char *fetch_url(const char *url)
 {
        struct ucontent *content = malloc(sizeof(struct ucontent));
-       char *result = NULL;
+       char *result;
        long code;
+       int retries;
 
        if (debug)
                printf("DEBUG: fetch_url %s\n", url);
 
        if (!curl) {
+               if (debug)
+                       printf("DEBUG: initializing CURL\n");
                curl_global_init(CURL_GLOBAL_ALL);
                curl = curl_easy_init();
        }
@@ -72,6 +78,11 @@ static char *fetch_url(const char *url)
        if (!curl)
                exit(EXIT_FAILURE);
 
+       result = NULL;
+
+       retries = DEFAULT_FETCH_RETRIES;
+
+ retrieve:
        content->data = malloc(1);
        content->data[0] = '\0';
        content->len = 0;
@@ -83,10 +94,34 @@ static char *fetch_url(const char *url)
        curl_easy_setopt(curl, CURLOPT_USERAGENT, "ppastats/0.0");
 
        if (curl_easy_perform(curl) == CURLE_OK) {
-
                curl_easy_getinfo(curl, CURLINFO_RESPONSE_CODE, &code);
-               if (code == 200)
+
+               switch (code) {
+               case 200:
                        result = content->data;
+                       break;
+               case 500:
+               case 502:
+               case 503:
+               case 504:
+                       if (retries) {
+                               fprintf(stderr,
+                                       "Fetch failed: with code %ld "
+                                       "for URL= %s\n",
+                                       code,
+                                       url);
+
+                               if (debug)
+                                       printf("Wait 5s before retry.\n");
+                               sleep(5);
+
+                               free(content->data);
+                               retries--;
+                               goto retrieve;
+                       }
+               default:
+                       fprintf(stderr, "Fetch failed: %ld\n", code);
+               }
        }
 
        if (!result)
@@ -115,29 +150,51 @@ static json_object *get_json_object(const char *url)
        return NULL;
 }
 
+#define json_object_to_bpph_list \
+json_object_to_binary_package_publishing_history_list
+
 struct binary_package_publishing_history * *
-get_binary_package_publishing_history_list(const char *archive_url)
+get_binary_package_publishing_history_list(const char *archive_url,
+                                          const char *pkg_status)
 {
-       char *url = malloc(strlen(archive_url)+
-                          strlen(QUERY_GET_PUBLISHED_BINARIES)+
-                          1);
+       struct json_object *o_next;
+       char *url;
        json_object *o;
-       struct binary_package_publishing_history **result;
+       void **result = NULL;
+
+       url = malloc(strlen(archive_url)+
+                    strlen(QUERY_GET_PUBLISHED_BINARIES)+
+                    (pkg_status ? strlen("&status=")+strlen(pkg_status) : 0)+
+                    1);
 
        strcpy(url, archive_url);
        strcat(url, QUERY_GET_PUBLISHED_BINARIES);
 
-       o = get_json_object(url);
-       free(url);
+       if (pkg_status) {
+               strcat(url, "&status=");
+               strcat(url, pkg_status);
+       }
 
-       if (!o)
-               return NULL;
+       while (url) {
+               o = get_json_object(url);
+               free(url);
+               url = NULL;
 
-       result = json_object_to_binary_package_publishing_history_list(o);
+               if (!o)
+                       break;
 
-       json_object_put(o);
+               result = list_append_list(result,
+                                         (void **)json_object_to_bpph_list(o));
 
-       return result;
+               o_next = json_object_object_get(o, "next_collection_link");
+
+               if (o_next)
+                       url = strdup(json_object_get_string(o_next));
+
+               json_object_put(o);
+       }
+
+       return (struct binary_package_publishing_history **)result;
 }
 
 int get_download_count(const char *archive_url)