projects
/
pnews.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
avoid duplicate article instances
[pnews.git]
/
war
/
src
/
main
/
java
/
pnews
/
servlet
/
ArticleProvider.java
diff --git
a/war/src/main/java/pnews/servlet/ArticleProvider.java
b/war/src/main/java/pnews/servlet/ArticleProvider.java
index
b28bbf5
..
d3e4f3d
100644
(file)
--- a/
war/src/main/java/pnews/servlet/ArticleProvider.java
+++ b/
war/src/main/java/pnews/servlet/ArticleProvider.java
@@
-120,10
+120,10
@@
public class ArticleProvider {
return false;
}
return false;
}
- private
Article toArticle(String link, Category cat
, SyndEntry entry, SyndFeed feed) {
+ private
static Article toArticle(String link
, SyndEntry entry, SyndFeed feed) {
String desc, title, thumbnail;
Date date;
String desc, title, thumbnail;
Date date;
-
+
thumbnail = null;
for (SyndEnclosure e: entry.getEnclosures()) {
if (e.getType().startsWith("image/"))
thumbnail = null;
for (SyndEnclosure e: entry.getEnclosures()) {
if (e.getType().startsWith("image/"))
@@
-149,36
+149,27
@@
public class ArticleProvider {
if (date == null)
LOG.severe("The article " + feed.getTitle() + " - " + title + " does not have a date");
if (date == null)
LOG.severe("The article " + feed.getTitle() + " - " + title + " does not have a date");
- return new Article(link,
cat,
title, desc, thumbnail, date, title);
+ return new Article(link, title, desc, thumbnail, date, title);
}
}
-
-
private void addArticles(Category cat, SyndFeed feed) {
private void addArticles(Category cat, SyndFeed feed) {
- String thumbnail;
- String desc, link, title, feedTitle, feedImage;
- Date date;
+ String feedTitle;
List<Article> articles;
Article a;
feedTitle = feed.getTitle().trim();
List<Article> articles;
Article a;
feedTitle = feed.getTitle().trim();
- if (feed.getImage() != null)
- feedImage = feed.getImage().getUrl();
- else
- feedImage = null;
-
LOG.info("addArticles " + cat.getId() + " " + feedTitle + " number of articles: " + feed.getEntries().size());
for (SyndEntry entry: feed.getEntries()) {
LOG.info("addArticles " + cat.getId() + " " + feedTitle + " number of articles: " + feed.getEntries().size());
for (SyndEntry entry: feed.getEntries()) {
- link = entry.getLink().trim();
+
String
link = entry.getLink().trim();
articles = getArticlesForUpdate(cat);
if (exists(link, articles)) {
LOG.fine("addArticles " + link + " is already present");
continue ;
}
articles = getArticlesForUpdate(cat);
if (exists(link, articles)) {
LOG.fine("addArticles " + link + " is already present");
continue ;
}
- a =
toArticle(link, cat, entry, feed
);
+ a =
ArticleStore.singleton.getArticle(link, ()->toArticle(link, entry, feed)
);
synchronized (articles) {
articles.add(a);
synchronized (articles) {
articles.add(a);
@@
-194,14
+185,13
@@
public class ArticleProvider {
return -1;
return o2.publicationDate.compareTo(o1.publicationDate);
}
return -1;
return o2.publicationDate.compareTo(o1.publicationDate);
}
-
});
}
}
LOG.info("addArticles done " + cat.getId());
}
});
}
}
LOG.info("addArticles done " + cat.getId());
}
-
+
private void retrieveArticles(Category cat) throws IllegalArgumentException, MalformedURLException, FeedException, IOException {
String[] feeds;
private void retrieveArticles(Category cat) throws IllegalArgumentException, MalformedURLException, FeedException, IOException {
String[] feeds;